Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DateTimePicker] Ensure toolbar viewType is correctly updated #7942

Merged
merged 2 commits into from
Feb 20, 2023
Merged

[DateTimePicker] Ensure toolbar viewType is correctly updated #7942

merged 2 commits into from
Feb 20, 2023

Conversation

LukasTy
Copy link
Member

@LukasTy LukasTy commented Feb 14, 2023

Noticed that the aria-label on the editing mode button doesn't change when switching tabs or changing view by clicking toolbar sections.

  • ensure the viewType is dynamically updated from DateTimePickerToolbar;
  • create a type for 'calendar' | 'clock'
  • remove redundant types in localization files

@LukasTy LukasTy added bug 🐛 Something doesn't work component: pickers This is the name of the generic UI component, not the React module! component: DateTimePicker The React component. labels Feb 14, 2023
@LukasTy LukasTy self-assigned this Feb 14, 2023
@mui-bot
Copy link

mui-bot commented Feb 14, 2023

These are the results for the performance tests:

Test case Unit Min Max Median Mean σ
Filter 100k rows ms 583.3 1,011.2 646.6 724.94 150.222
Sort 100k rows ms 622.3 1,097.2 844.8 883.22 156.396
Select 100k rows ms 224 318.3 266.6 267.78 38.681
Deselect 100k rows ms 147.7 291.7 194.6 202.46 48.72

Generated by 🚫 dangerJS against 4f136fa

flaviendelangle
flaviendelangle reviewed Feb 15, 2023
View reviewed changes
Copy link
Member

@flaviendelangle flaviendelangle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we only have these issues on the master branch or do we need to port some of them to next ?

@LukasTy
Copy link
Member Author

LukasTy commented Feb 16, 2023

Do we only have these issues on the master branch or do we need to port some of them to next?

Toolbar is viewType agnostic in "next" because we've removed the toggle between calendar and text input. 😉

@LukasTy LukasTy merged commit 09f0780 into mui:master Feb 20, 2023
@LukasTy LukasTy deleted the fix-date-time-toolbar-view-type branch February 20, 2023 08:12
@Chanuth-silva10 Chanuth-silva10 mentioned this pull request Jul 17, 2024
Open
This was referenced Aug 31, 2024
Closed
Closed
@dexamundsen dexamundsen mentioned this pull request Sep 20, 2024
Closed
@dexamundsen dexamundsen mentioned this pull request Oct 4, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flaviendelangle flaviendelangle flaviendelangle approved these changes

@alexfauquette alexfauquette Awaiting requested review from alexfauquette

Assignees

@LukasTy LukasTy

Labels
bug 🐛 Something doesn't work component: DateTimePicker The React component. component: pickers This is the name of the generic UI component, not the React module!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@LukasTy @mui-bot @flaviendelangle